Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix cross-compiled Windows builds and manual-release tiles OSX builds #6057

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

RobbieNeko
Copy link
Collaborator

Purpose of change (The Why)

In the words of CGP Grey: "1 is none. 2 is one. If it's important, have a backup."

SQLite-save PR passed over the non-MSVC Windows builds, and as it turns out the manual release's build command on OSX builds has been broken the entire time? (Or at least for 2 years). Having a redundant Windows build is a great idea for when MSVC is being weird, and I'm sure the OSX users would like

Describe the solution (The How)

  • Add SQLite dependencies to the cross-compile build for Windows
  • Copy over the Nightly release's build command for OSX manual releases

Describe alternatives you've considered

  • Let them suffer, it builds character!

Testing

I used my eyes and made sure I was copy-pasting the right things.

Proper testing shall come with actual build attempts

Additional context

At least OSX users have the Nightlies already

Checklist

Mandatory

@RobbieNeko
Copy link
Collaborator Author

I can assure you, fixing OSX and windows builds does not change anything related to movement.

That test is just deciding to be very funny today

Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicates are evil

@scarf005 scarf005 merged commit dcb5663 into cataclysmbnteam:main Feb 6, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants