Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: water dispensers and purifers don't erase inherited flags anymore #6078

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

chaosvolt
Copy link
Member

Purpose of change (The Why)

Fixes #6077

Describe the solution (The How)

Turns out water dispensers, and water purifiers for that matter, just copy from water heaters which already have the flag that #6005 accidentraly overrided their flags to give. So literally just a simple matter of deleting the redundant flag override since they already inherit ADV_DECONSTRUCT from water heaters, doi.

Describe alternatives you've considered

screm

Testing

  1. Load-tested in compiled test build.
  2. Spawned in a mine, checked the water dispenser to confirm it doesn't hold dirty water.
  3. Can also actually pour the water into a container or try to drink it.

Additional context

images

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Feb 11, 2025
@chaosvolt chaosvolt enabled auto-merge (squash) February 11, 2025 20:03
Copy link
Collaborator

@RobbieNeko RobbieNeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly plumbing features, overwriting flags so blatantly

@chaosvolt chaosvolt merged commit 7afca08 into main Feb 11, 2025
13 checks passed
@chaosvolt chaosvolt deleted the needa-dispenser-here branch February 11, 2025 20:31
Goredell pushed a commit to Goredell/Cataclysm-BN that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Water dispenser are broken
2 participants