Revert "Issue #358: Added some extra styling for outage icons"

[djarran]

Description: Revert #359. The changes affect the icon sizes when used in previous Moodle versions:

Before commit:

After commit (in both 3.9 and 4.1):

[bwalkerl]

Thanks @djarran

The code here is fine, but I'm a bit torn about the revert. It seems to be a balancing act of 4.5 being very broken vs older versions having slightly larger icons. This issue still requires further attention, but as this isn't very noticeable to non-admin users I think it might be better to leave it as is until we get a proper fix?

But in saying that I'm happy to merge if you feel strongly about this.

[djarran]

Thanks @djarran

The code here is fine, but I'm a bit torn about the revert. It seems to be a balancing act of 4.5 being very broken vs older versions having slightly larger icons. This isn't very noticeable to non-admin users so I think it might be better to leave it as is and get a proper fix instead?

But in saying that I'm happy to merge if you feel strongly about this.

The idea behind the revert was that we would then create a new stable branch for Moodle 4.5 to apply these changes, as this causes a minor regression in sub-Moodle 4.5 versions.

Having said that, the proper fix seems to be to use pix_icon as opposed to html_writer::empty_tag. I'll verify that this solution works on all stable branches

[djarran]

Closing this PR in favour of #361