Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite student_search_table query #152

Merged

Conversation

marxjohnson
Copy link
Contributor

Details on internal WR 427905

@marxjohnson marxjohnson force-pushed the student-search-query_400 branch from ba75842 to 0e8c730 Compare February 12, 2024 12:00
@marxjohnson marxjohnson force-pushed the student-search-query_400 branch from 465236d to 35593ab Compare February 13, 2024 10:44
Copy link

@SimonThornett SimonThornett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved. Resolves underlying issue.

Re-formatting for consistency and traits to replace duplicate code all good.

Copy link

@daledavies daledavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been reviewed by @SimonThornett so approving.

@marxjohnson marxjohnson merged commit 1b9dd43 into catalyst:MOODLE_400_STABLE Feb 14, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants