Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow multiple emails in Notify on abort to fix #881 #882

Merged
merged 1 commit into from
Jun 2, 2024
Merged

feat: allow multiple emails in Notify on abort to fix #881 #882

merged 1 commit into from
Jun 2, 2024

Conversation

dmitriim
Copy link
Member

No description provided.

@matthewhilton
Copy link
Contributor

Closes #882

matthewhilton
matthewhilton approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@matthewhilton matthewhilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Would be good to see unit tests but since there weren't any for the single email function before I won't let that be a blocker.

Gave it a quick test on my local and worked as expected.

@matthewhilton matthewhilton merged commit 0488b2e into MOODLE_401_STABLE Jun 2, 2024
15 checks passed
@matthewhilton matthewhilton deleted the issue881 branch June 2, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhilton matthewhilton matthewhilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitriim @matthewhilton