Bugfix for store allocation array, now returns string element

catalyst · Nov 11, 2021 · db9a83e · db9a83e
1 parent 90d5809
commit db9a83e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/classes/cache_config.php b/classes/cache_config.php
@@ -297,7 +297,7 @@ private function generate_mode_mapping($rules): array {
                 // Check if the rule has any conditions, if not it will be set
                 // as the default store as it is considered the broadest rule.
                 if (empty($lastrule['conditions'])) {
-                    $modemapping['store'] = $lastrule['stores'];
+                    $modemapping['store'] = reset($lastrule['stores']);
                 }
             }
             return $modemapping;

diff --git a/tests/fixtures/mode_mappings_data.php b/tests/fixtures/mode_mappings_data.php
@@ -37,9 +37,7 @@
 $generatedmodemappingagainstdefinitionmatchtoprulesetexpected = array(
     array(
         'mode' => cache_store::MODE_APPLICATION,
-        'store' => array(
-            'file-test'
-        ),
+        'store' => 'file-test',
         'sort' => -1
     ),
     array(