Support custom locks #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this - there is no way to define custom lock instances and the default
file locking is forced.
This lets you define your own:
```
$CFG->tool_forcedcache_config_array = [
'locks' => [
'muclock_default' => [
'name' => 'Example custom lock',
'type' => 'cachelock_file',
],
],
];
```
|
|
||
| // Then check the lock plugins exist. | ||
| $pluginname = substr($lock['type'], 10); | ||
| $cachepath = __DIR__.'/../../../../cache/locks/' . $pluginname . '/lib.php'; |
There was a problem hiding this comment.
The $CFG object should be available here, so it will be a little cleaner to use $CFG->wwwroot . '/cache...'
There was a problem hiding this comment.
$CFG->dirroot rather - but otherwise sure.
|
Thanks @aolley for your PRs against the plugin, overall they look great, and your contributions are appreciated. I will be able to test these next week in a real environment, but It may be nice to implement some unit tests for these features as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this - there is no way to define custom lock instances and the default
file locking is forced.
This lets you define your own: