-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chunking bug with compound dtypes #1146
base: main
Are you sure you want to change the base?
Conversation
@rly, lmk what you think |
@h-mayorquin, this is ready for review. Basically I use the hdmf.build.builders.BaseBuilder to check if a neurodata object would have a compound dtype. Most of the complexity is introduced by the need to find a match between the neurodata object and its location in the builder, which is outlined in the docstrings. Lmk what you think! |
I did a first reading. Two things:
|
I updated to include everything <4, which zarr-related issues. Should be able to add hdmf 4.0 soon -- see: #1191 |
Definitely needs some unit tests. I'll put together some. |
From Meeting: move has_compound_dtype inside get_data_shape |
Actually, |
@h-mayorquin, i added tests, so this should be good to go! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
==========================================
- Coverage 90.69% 89.72% -0.98%
==========================================
Files 129 129
Lines 8189 8415 +226
==========================================
+ Hits 7427 7550 +123
- Misses 762 865 +103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #1122
Comapare Dev Tests after the fix: https://github.com/catalystneuro/neuroconv/actions/runs/12960177532/job/36153641201 (2 failed -- see #1188)
To Dev Tests before: https://github.com/catalystneuro/neuroconv/actions/runs/12995279932/job/36241639533 (8 failed)