Detect mismatch errors between group and group names when writing ElectrodeGroups
#1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
changed the title
ElectrodeGroups
h-mayorquin
commented
Dec 18, 2024
| @@ -259,6 +267,23 @@ def _get_group_name(recording: BaseRecording) -> np.ndarray: | |||
| # If for any reason the group names are empty, fill them with the default | |||
| group_names[group_names == ""] = default_value | |||
|
|
|||
| # Validate group names against groups | |||
| if groups is not None: | |||
| unique_groups = np.unique(groups) | |||
There was a problem hiding this comment.
Mmm I will change this to sets as I remember np.unique being buggy for strings.
There was a problem hiding this comment.
Made the correction.
alejoe91
approved these changes
Dec 19, 2024
| """ | ||
| default_value = "ElectrodeGroup" | ||
| group_names = recording.get_property("group_name") | ||
| groups = recording.get_channel_groups() |
There was a problem hiding this comment.
I think this us never None, so L262 will never be reached
h-mayorquin
deleted the
add_electrode_group_and_mismatch_test_on_spikeinterface
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 90.69% 90.12% -0.58%
==========================================
Files 129 129
Lines 8189 8300 +111
==========================================
+ Hits 7427 7480 +53
- Misses 762 820 +58
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should come after #1164 and has it as its base.
This should close #932 as we have now a function that decides the right priority between "group_name" and "group". This PR adds some errors for two different types of mismatch:
@alejoe91 could you take a look?