Adds support for video and intrinsic signal optical imaging to convert_all_sessions and convert_session #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
h-mayorquin
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Can't really see the dandi set and at this stage it seems that that's probably the best way of looking at this but as Paul mentioned it is just to have to take a glance to have a second pair of eyes.
Looks good to me, some comments that need not be addressed.
src/schneider_lab_to_nwb/zempolich_2024/zempolich_2024_intrinsic_signal_imaging_interface.py
Show resolved
Hide resolved
I added you as an owner, so now you should be able to look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have video and ISOI data from schneider lab, this PR incorporates the new data into the conversion.
See Dandiset for updated example files: https://dandiarchive.org/dandiset/001259/draft