-
-
Notifications
You must be signed in to change notification settings - Fork 329
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: show
config.toml
and user data in Terraform plan (#754)
## Description ### What Adds a new variable `show_user_data_in_plan` which is `false` by default (there could be sensitive data leaked). * Writes the rendered `config.toml` to a file * Writes the agent's user data to a file. ### Why * By writing the rendered `config.toml` to a file we get an actual diff of the `config.toml` when we change values in our Terraform plan. In addition this would help us with the refactoring work were currently doing. * Even better ability to see the impact of changes we make. ## Migrations required NO ## Verification `show_user_data_in_plan = true` ![image](https://user-images.githubusercontent.com/17970041/225928978-cd8b31b0-9fbf-4cdb-89b3-8885a4d52f99.png) Example of `config.toml` showing a diff in plan: ![image](https://user-images.githubusercontent.com/17970041/225929105-ff04ae01-39c0-40cc-adb0-5181f5a94b46.png) --------- Co-authored-by: Matthias Kay <[email protected]> Co-authored-by: kayma <[email protected]>
- Loading branch information
1 parent
ac0ca54
commit 5b5c335
Showing
11 changed files
with
121 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,3 +38,6 @@ builds/ | |
|
||
# Python | ||
venv/ | ||
|
||
# Terraform rendered templates | ||
debug/ |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.