Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/search-history #599

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

qubisc00
Copy link

@qubisc00 qubisc00 commented Jan 20, 2025

Hi!,

Some long time ago, I have added a basic search history to your project, cause I needed it, but have never considered to publish the code.

I have added some basic UI, which is not perfect. If you like the solution I would improve the MR so it would be merge ready. I am no gtk/c dev but I tried my best, so feedback is welcome.

How it works:

  • History is saved to a .csv file which is located in the home directory.
  • It stores the search query and the timestamp so you could sort by both.
  • The completion opens when you type something or double click on the search entry.

Whats not working:

  • The UI broke the current one, if you click to add a path to the database, the wrong index is called in the preferences settings. (I would renew the UI, but i am also not sure if the history needs its own tab in the notebook, should be discussed)
  • Double click does not work on the initial state, you have to type something before. E.g. just type a space, remove it and then you can double click. Not sure why its not working, might be some search entry property, which cannot be overwritten?.
  • You need to restart the application if you enable/disable history. But this can be easily fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant