Upgrate SPDM 1.3 Version Support #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntelCaisui
force-pushed
the
spdm13_version_support
branch
from
0e6bbd2 to
2f6fc74
Compare
jyao1
reviewed
Dec 17, 2024
jyao1
reviewed
Dec 17, 2024
jyao1
reviewed
Dec 17, 2024
jyao1
reviewed
Dec 17, 2024
|
This patch includes many optional changes that should not be included to handle #135. |
IntelCaisui
force-pushed
the
spdm13_version_support
branch
from
2f6fc74 to
ef5aeb1
Compare
IntelCaisui
commented
Dec 17, 2024
| @@ -80,6 +80,8 @@ fn test_case0_handle_spdm_version() { | |||
| assert_eq!(payload.versions[1].version, SpdmVersion::SpdmVersion11); | |||
| assert_eq!(payload.versions[2].update, 0); | |||
| assert_eq!(payload.versions[2].version, SpdmVersion::SpdmVersion12); | |||
| assert_eq!(payload.versions[3].update, 0); | |||
There was a problem hiding this comment.
Add check for SpdmVersion13 entry generation in spdm_version_reponse unit test.
IntelCaisui
commented
Dec 17, 2024
| @@ -177,7 +177,7 @@ pub fn req_create_info() -> (SpdmConfigInfo, SpdmProvisionInfo) { | |||
| Some(SpdmVersion::SpdmVersion10), | |||
| Some(SpdmVersion::SpdmVersion11), | |||
| Some(SpdmVersion::SpdmVersion12), | |||
| None, | |||
| Some(SpdmVersion::SpdmVersion13), | |||
There was a problem hiding this comment.
Add SpdmVersion13 config in spdmlib-test.
Fix ccc-spdm-tools#135 This Patch adds spdm 1.3 version support 1. Remains version configs of requester/responder as spdm 1.2 to avoid version negotiated to 1.3 since spdm 1.3 required features are not ready. 2. Remains UpdateVersionNumber of VersionNumberEntry for version 1.3 in Ger_Version Response as 0. Will track the updating to 1.3.2 (most recent) in another issue.
IntelCaisui
force-pushed
the
spdm13_version_support
branch
from
ef5aeb1 to
dee2060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #135
This Patch adds spdm 1.3 version support
since spdm 1.3 required features are not ready.
0. Will track the updating to 1.3.2 (most recent in other issuee).