Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warning in ring library #156

Merged

Conversation

zlukwins
Copy link
Contributor

The following warning is being fixed:

warning: unused imports: PKCS1, PSS
--> ring/src/rsa/padding.rs:21:13
|
21 | pkcs1::{PKCS1, RSA_PKCS1_SHA256, RSA_PKCS1_SHA384, RSA_PKCS1_SHA512},
| ^^^^^
22 | pss::{PSS, RSA_PSS_SHA256, RSA_PSS_SHA384, RSA_PSS_SHA512},
| ^^^
|
= note: #[warn(unused_imports)] on by default

That warning was already fixed with this patch:
briansmith/ring@c4742e0

Once ring library version will be bumped up, this patch could be dropped.

The following warning is being fixed:

warning: unused imports: `PKCS1`, `PSS`
  --> ring/src/rsa/padding.rs:21:13
   |
21 |     pkcs1::{PKCS1, RSA_PKCS1_SHA256, RSA_PKCS1_SHA384, RSA_PKCS1_SHA512},
   |             ^^^^^
22 |     pss::{PSS, RSA_PSS_SHA256, RSA_PSS_SHA384, RSA_PSS_SHA512},
   |           ^^^
   |
   = note: `#[warn(unused_imports)]` on by default

That warning was already fixed with this patch:
briansmith/ring@c4742e0

Once ring library version will be bumped up, this patch could be dropped.

Signed-off-by: Zbigniew Lukwinski <[email protected]>
@jyao1 jyao1 closed this Dec 18, 2024
@jyao1 jyao1 reopened this Dec 18, 2024
@jyao1 jyao1 merged commit fac5664 into ccc-spdm-tools:main Dec 19, 2024
95 of 102 checks passed
@zlukwins zlukwins deleted the fix-compilation-warnings-in-ring-library branch December 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants