Fix sender can not receive err msg after key update fail #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OuyangHang33 <[email protected]>
…rect UpdateAllKeys operation Signed-off-by: OuyangHang33 <[email protected]>
OuyangHang33
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #7
When SPDM-rs Requester create new keys and send wrong KeyUpdate operation, it can't receive Err msg from responder.
Solution:
When meet Generic failure, try backup keys before aborting. Retry decoding message with backup Requester key.
Tested with Rust SPDM emulator:
Requester send wrong UpdateAllKeys operation request and update responder key. responder send
[12, 7F, 01, 00]err message, and requester can receive this message.