Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the gc-org data from s3 #2426

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Get the gc-org data from s3 #2426

wants to merge 3 commits into from

Conversation

smcmurtry
Copy link
Contributor

Summary | Résumé

This PR switches where we are loading the gc-organisation data from to S3 to improve reliability.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Run locally with the following new line in your .env file:

GC_ORGANISATIONS_BUCKET_NAME=notification-canada-ca-staging-gc-organisations

Run the admin app and test creating a new service with an organisation from the dropdown list. You should be able to create the service successfully with no API errors.

Release Instructions | Instructions pour le déploiement

None. The new env variable is already in staging and prod.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant