Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miasm version #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serpilliere
Copy link
Contributor

The miasm_engine renaming is mandatory to avoid a namespace collision:

    from sibyl.engine.qemu import QEMUEngine                                                              
  File "python2.7/site-packages/sibyl/engine/qemu.py", line 1, in <module>
    from miasm.core.utils import pck32, pck64                                                             
ImportError: No module named core.utils                                                                   

README.md Outdated
@@ -167,7 +167,7 @@ Installation

### Standard

_Sibyl_ requires at least _Miasm2_ version `v0.1.1` and the corresponding version of _Elfesteem_.
_Sibyl_ requires at least _Miasm_ version `v0.1.3` and the corresponding version of _Elfesteem_.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Sibyl_ requires at least _Miasm_ version `v0.1.3` and the corresponding version of _Elfesteem_.
_Sibyl_ requires at least _Miasm_ version `v0.1.3`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
I forgot to remove the installation of elfesteem as well, and the use of elfesteem in the code instead of miasm loader

@serpilliere serpilliere force-pushed the update_miasm branch 7 times, most recently from dbe9955 to dfc99fe Compare June 9, 2020 09:38
@serpilliere serpilliere added the wip label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants