Skip to content

Commit

Permalink
dont NUL terminate _NET_WM_NAME
Browse files Browse the repository at this point in the history
Reported by Kernc, thanks!

"This makes a particular program that uses libwnck [1] fail after:

    Wnck-WARNING **: Property _NET_WM_NAME contained invalid UTF-8

in this code [2] because the returned string contains a '\0' and the
documentation for g_utf8_validate() [3] explicitly states that when
string length is provided, no nul bytes are allowed."

It is not entirely clear it is incorrect, other WM's seem to not
NUL terminate it either though.
  • Loading branch information
hiltjo committed Dec 27, 2017
1 parent 3756f7f commit db22360
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dwm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1579,7 +1579,7 @@ setup(void)
XChangeProperty(dpy, wmcheckwin, netatom[NetWMCheck], XA_WINDOW, 32,
PropModeReplace, (unsigned char *) &wmcheckwin, 1);
XChangeProperty(dpy, wmcheckwin, netatom[NetWMName], utf8string, 8,
PropModeReplace, (unsigned char *) "dwm", 4);
PropModeReplace, (unsigned char *) "dwm", 3);
XChangeProperty(dpy, root, netatom[NetWMCheck], XA_WINDOW, 32,
PropModeReplace, (unsigned char *) &wmcheckwin, 1);
/* EWMH support per view */
Expand Down

0 comments on commit db22360

Please sign in to comment.