Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPF - Fix Chinese IME character Composition issue #3163

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

yeyezizhi
Copy link
Contributor

@yeyezizhi yeyezizhi commented Jul 1, 2020

Issue:

#1262

Summary:

Changes:

  • CefSharp.Wpf.Experimental.WpfImeKeyboardHandler.cs is modified.
    from

    if (languageCodeId == ImeNative.LANG_KOREAN) {...}

    to

    if (languageCodeId == ImeNative.LANG_KOREAN || languageCodeId == ImeNative.LANG_CHINESE) {...}

How Has This Been Tested?

  • I have tested Chinese IME on windows 10, version 2004, and it works well.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@AppVeyorBot
Copy link

@amaitland
Copy link
Member

Please add a comment to #1262 detailing your proposed change so others using the feature are kept up to date. Please include as much detail as possible.

@amaitland amaitland added this to the 83.4.x milestone Jul 1, 2020
@amaitland amaitland merged commit ccd4af8 into cefsharp:master Jul 1, 2020
@amaitland
Copy link
Member

As I have no means of testing this I'm merging as is, it will be included in the 83.4.x. release.

Please make sure to update #1262 with details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants