Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Python 3.12 in the CI #1812

Merged
merged 4 commits into from
Oct 18, 2023
Merged

added Python 3.12 in the CI #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa4d4f5
added Python 3.12 in the CI
auvipy Oct 12, 2023
c4a5b3c
try to make kafka work on py3.12
auvipy Oct 12, 2023
67af9dc
skip kafka for the time being as it seems not woring with py3.12 yet
auvipy Oct 12, 2023
4c9edc1
using assert_called_once()
auvipy Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8,3.9,"3.10","3.11"]
python-version: [3.8,3.9,"3.10","3.11","3.12"]
steps:
- name: Install system packages
run: sudo apt-get update && sudo apt-get install libcurl4-openssl-dev libssl-dev
Expand All @@ -29,7 +29,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.8,3.9,"3.10","3.11"]
python-version: [3.8,3.9,"3.10","3.11","3.12"]
experimental: [false]
include:
- python-version: pypy3.9
Expand Down
2 changes: 1 addition & 1 deletion t/unit/asynchronous/test_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def test_call_soon_uses_lock(self):
callback = Mock(name='callback')
with patch.object(self.hub, '_ready_lock', autospec=True) as lock:
self.hub.call_soon(callback)
assert lock.__enter__.called_once()
lock.__enter__.assert_called_once()

def test_call_soon__promise_argument(self):
callback = promise(Mock(name='callback'), (1, 2, 3))
Expand Down
14 changes: 8 additions & 6 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tox]
envlist =
{pypy3.9,3.8,3.9,3.10,3.11}-unit
{pypy3.9,3.8,3.9,3.10,3.11}-linux-integration-py-amqp
{pypy3.9,3.8,3.9,3.10,3.11,3.12}-unit
{pypy3.9,3.8,3.9,3.10,3.11,3.12}-linux-integration-py-amqp
{pypy3.9,3.8,3.9,3.10,3.11}-linux-integration-redis
{pypy3.9,3.8,3.9,3.10,3.11}-linux-integration-mongodb
{3.8,3.9,3.10,3.11}-linux-integration-kafka
Expand All @@ -17,6 +17,7 @@ python =
3.9: py39
3.10: py310, mypy
3.11: py311
3.12: py312

[testenv]
sitepackages = False
Expand All @@ -25,9 +26,9 @@ passenv =
DISTUTILS_USE_SDK
deps=
-r{toxinidir}/requirements/dev.txt
apicheck,pypy3.9,3.8,3.9,3.10,3.11: -r{toxinidir}/requirements/default.txt
apicheck,pypy3.9,3.8,3.9,3.10,3.11: -r{toxinidir}/requirements/test.txt
apicheck,pypy3.9,3.8,3.9,3.10,3.11: -r{toxinidir}/requirements/test-ci.txt
apicheck,pypy3.9,3.8,3.9,3.10,3.11,3.12: -r{toxinidir}/requirements/default.txt
apicheck,pypy3.9,3.8,3.9,3.10,3.11,3.12: -r{toxinidir}/requirements/test.txt
apicheck,pypy3.9,3.8,3.9,3.10,3.11,3.12: -r{toxinidir}/requirements/test-ci.txt
apicheck,3.8-linux,3.9-linux,3.10-linux,3.11-linux: -r{toxinidir}/requirements/extras/confluentkafka.txt
apicheck,linkcheck: -r{toxinidir}/requirements/docs.txt
flake8,pydocstyle,mypy: -r{toxinidir}/requirements/pkgutils.txt
Expand All @@ -46,6 +47,7 @@ basepython =
3.9: python3.9
3.10,apicheck,pydocstyle,flake8,linkcheck,cov,mypy: python3.10
3.11: python3.11
3.12: python3.12

install_command = python -m pip --disable-pip-version-check install {opts} {packages}

Expand Down Expand Up @@ -131,4 +133,4 @@ commands =
pydocstyle {toxinidir}/kombu

[testenv:mypy]
commands = python -m mypy --config-file setup.cfg
commands = python -m mypy --config-file setup.cfg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to configure your editor to automatically end a file with a linebreak ;)

Loading