cip-19!: simplify Bitswap compostion #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the status of the CIP is still
Review
, we want to make a protocol-breaking amendment to Shwap prompted by the ongoing production-ready implementation. This change simplifies the protocol, particularly the Bitswap composition, by making a single protobuf definition of a Block instead of N definitions per every current and future Container type.This change is motivated by a desire to make it easier for Shwap to extend horizontally in the abstract specification and its implementations. Previously, the new container would have to be added to both the core Shwap container specification and the Bitswap composition. Now, only a single place needs to be updated(and Bitswap codec registry).
Besides, decoupling Shwap's and composition's protobuf definitions significantly improved cohesion across the layers.