Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cip-19!: simplify Bitswap compostion #159

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Jun 20, 2024

While the status of the CIP is still Review, we want to make a protocol-breaking amendment to Shwap prompted by the ongoing production-ready implementation. This change simplifies the protocol, particularly the Bitswap composition, by making a single protobuf definition of a Block instead of N definitions per every current and future Container type.

This change is motivated by a desire to make it easier for Shwap to extend horizontally in the abstract specification and its implementations. Previously, the new container would have to be added to both the core Shwap container specification and the Bitswap composition. Now, only a single place needs to be updated(and Bitswap codec registry).

Besides, decoupling Shwap's and composition's protobuf definitions significantly improved cohesion across the layers.

@Wondertan
Copy link
Member Author

(Noting that we should not rush moving Shwap to Final, as we figured there is one more feature needs to be added -- ability to request only Container proofs without its data)

@jcstein jcstein merged commit 47b4349 into celestiaorg:main Jun 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants