Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix da rpc check #356

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix(cli): fix da rpc check #356

merged 2 commits into from
Feb 13, 2024

Conversation

tuxcanfly
Copy link
Collaborator

@tuxcanfly tuxcanfly commented Feb 10, 2024 •
edited
Loading

Overview

This PR fixes the validation for the dial address of the DA gRPC service.

Valid addresses:

  • localhost:26650
  • 127.0.0.1:26650
  • :26650

Invalid addresses:

  • localhost
  • 127.0.0.1

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@tuxcanfly tuxcanfly requested a review from Ferret-san February 12, 2024 23:26
@tuxcanfly tuxcanfly merged commit 68e0eee into celestia-develop Feb 13, 2024
5 checks passed
@tuxcanfly tuxcanfly deleted the tux/fix-rpc-check branch February 13, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ferret-san Ferret-san Ferret-san approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxcanfly @Ferret-san