fix to_dict when there is no value

celinegrn · Jul 27, 2023 · 69935d1 · 69935d1
1 parent 8f75dc4
commit 69935d1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/mb_netmgmt/snmp.py b/mb_netmgmt/snmp.py
@@ -126,7 +126,12 @@ def decode(value):
 
 
 def to_dict(varbind):
+    val = None
+    tag = None
+    if varbind.value:
+        val = decode(varbind.value.val)
+        tag = str(varbind.value.tag)
     return {
-        "val": decode(varbind.value.val),
-        "tag": str(varbind.value.tag),
+        "val": val,
+        "tag": tag,
     }
diff --git a/test/test_mb_netmgmt.py b/test/test_mb_netmgmt.py
@@ -253,3 +253,9 @@ def test_to_dict():
     varbind = SNMPvarbind()
     result = snmp.to_dict(varbind)
     assert result == {"tag": "NULL", "val": 0}
+
+
+def test_no_such_instance_to_dict():
+    varbind = SNMPvarbind(value=None, noSuchInstance=0)
+    result = snmp.to_dict(varbind)
+    assert result == {"tag": None, "val": None}