-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support eth bridge module #358
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaBothara
force-pushed
the
support_ethBridge_module
branch
from
August 27, 2021 00:39
32019d1
to
b4db7de
Compare
…f bridge-contract
jordy25519
approved these changes
Sep 8, 2021
.github/workflows/ci.yml
Outdated
run: yarn build | ||
- name: start local Eth node | ||
run: | | ||
docker run --dns=127.0.0.1 -dit --name ethNode -p 8545:8545 -p 30303:30303 ethereumoptimism/hardhat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
docker run --dns=127.0.0.1 -dit --name ethNode -p 8545:8545 -p 30303:30303 ethereumoptimism/hardhat | |
docker run --dns=127.0.0.1 -d --name ethNode -p 8545:8545 -p 30303:30303 ethereumoptimism/hardhat |
don't need it
afaik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Merged
closing this cause of #407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Eth Bridge Module