make send asset a modal

[matjazc]

No description provided.

[KarishmaBothara]

Have tested it functionally on my local.. works well.. Can we remove the 'Send assets' from the left panel.. as per design now that will part of accounts page..

[aliXsed]

The code looks good to me as a non React/js expert. The PR can be improved by:

• Assigning it to the reviewers
• Adding a brief description explaining the approach
• Creating an issue on github (equivalent to our internal Jira task): Example issue Smart contract metadata is incompatible #31
• In the PR description mentioning if the above issue is fully addressed or not. Example: closes Smart contract metadata is incompatible #31

Also, the branch that you worked on could be better named something like feature/31-modal-send-asset. The first part "feature" specifies this is a new feature. If you were fixing an issue it could start with fix/ and so on. 31 is an example of an issue number that could be used in the branch name.
Having said this, you may notice we haven't fully followed the above-mentioned standard in our previous PRs and branch names. At the moment we take the above practice as an improvement guideline and we'd try to get better at it.

[matjazc]

Have tested it functionally on my local.. works well.. Can we remove the 'Send assets' from the left panel.. as per design now that will part of accounts page..

Sure, I will remove side bar item

[matjazc]

The code looks good to me as a non React/js expert. The PR can be improved by:

• Assigning it to the reviewers
• Adding a brief description explaining the approach
• Creating an issue on github (equivalent to our internal Jira task): Example issue Smart contract metadata is incompatible #31
• In the PR description mentioning if the above issue is fully addressed or not. Example: closes Smart contract metadata is incompatible #31

Also, the branch that you worked on could be better named something like feature/31-modal-send-asset. The first part "feature" specifies this is a new feature. If you were fixing an issue it could start with fix/ and so on. 31 is an example of an issue number that could be used in the branch name.
Having said this, you may notice we haven't fully followed the above-mentioned standard in our previous PRs and branch names. At the moment we take the above practice as an improvement guideline and we'd try to get better at it.

This is a nice set of good practices, I agree with all points. Thanks for raising this.

[jordy25519]

is there a way to close modal?

[matjazc]

new PR created