This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-application] Add theme density support to Terra Application and Dev Site #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhitasharma
suggested changes
Dec 19, 2023
| @@ -65,6 +65,10 @@ const propTypes = { | |||
| * The name of the theme to apply to the application using terra-theme-provider. | |||
| */ | |||
| themeName: PropTypes.string, | |||
| /** | |||
| * The name of the theme to apply to the application using terra-theme-provider. | |||
There was a problem hiding this comment.
This needs to be updated for theme density
nikhitasharma
approved these changes
Dec 21, 2023
adoroshk
approved these changes
Dec 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The terra-application and terra-dev-site packages were updated to support theme density in preparation for the new Redwood theme.
Why it was changed:
The change was made because the new Redwood theme has three data densities. The changes for this pull request allow applications to be configured to specify a density as well as properly test the density in components.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-10096
Thank you for contributing to Terra.
@cerner/terra