Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Miscellaneous repo updates #371

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Mar 28, 2024

Summary

This PR:

  • Updates .gitignore to only be relevant files
  • Enables package-lock and generates it
  • Removes redundant dependencies from the root package.json
  • Moves the eslint config into its dedicated file
  • Updates Github Actions to use npm ci instead of npm install
  • Moves dependencies to the correct location in sub-packages.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Mar 28, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-371 March 28, 2024 19:24 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-371 March 29, 2024 16:27 Destroyed
Copy link
Contributor

github-actions bot commented Mar 29, 2024

Fails
🚫 Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for:
  • terra-application
  • terra-dev-site
  • terra-polyfill

Generated by 🚫 dangerJS against 3a407c8

@github-actions github-actions bot temporarily deployed to preview-pr-371 March 29, 2024 17:38 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-371 March 29, 2024 18:09 Destroyed
@sdadn sdadn merged commit 4dc9b43 into terra-application-v1 Apr 1, 2024
6 of 7 checks passed
@sdadn sdadn deleted the update-repo-config branch April 1, 2024 14:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants