This repository has been archived by the owner on May 24, 2024. It is now read-only.
Update terra-functional-testing to 4 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artpark
approved these changes
Oct 31, 2023
|
Note: This PR will not pass the build as webpack 5 is not compatible with the current Karma 6. @adoroshk and I tried looking for an easy solution to address the incompatibility, however we couldn't find a quick & easy fix. At this point, it's better to switch over to Jest for better compatibility with the rest of the Terra ecosystem, then investing in extended time for a temporary fix. That work will be done in a subsequent PR/Jira. |
kenk2
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates terra-functional-testing to 4. As part of that upgrade, webpack was updated to 5 and npm 9 support was added.
Note: graphs only had the default-theme screenshots generated.
Testing
This change was tested using:
In addition to to wdio tests, this was tested by running
npm startsuccessfully after the webpack upgrade.Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves: UXPLATFORM-9601
Thank you for contributing to Terra.
@cerner/terra