Update Pie & Carbon API tests to use Jest #325
Conversation
| "@babel/runtime": "^7.10.4", | ||
| "@babel/cli": "^7", | ||
| "@babel/core": "7", | ||
| "@babel/plugin-transform-object-assign": "7", |
There was a problem hiding this comment.
Question: Any reason why we're fixing these packages to a specific version instead of the carat notation? Unless I'm mistaken won't this actually be a downgrade (because we're fixing to a specific version in this case)?
Also I feel that we should probably keep the semver fully specified so that we know where our last working version is in case any upstream shenanigans (like babel stuff) happens and we need a reference point to easily downgrade to.
There was a problem hiding this comment.
These aren't locking packages, it is just the shorter form of using the caret. We don't typically keep track of the minor versions of dev dependencies so this is just makes it clearer that we're using the "latest minor version of v7", especially with related dependencies that need to be on the same major version. It also makes future updates easier by needing to simply change the number.
There was a problem hiding this comment.
With caret:
With only major version:
Summary
This PR continues the work started in #324 to utilize Jest for unit tests instead of Karma.
This PR makes the following changes:
@babel/plugin-proposal-object-rest-spreadwith@babel/plugin-transform-object-rest-spread.Note: A small subset of tests are failing due to differing values or due to an undefined value in the graph API. These tests are being skipped for now as they require dedicated debugging and the current objective is to switch over to Jest for unit tests. These failing tests will be fixed in a separate Jira.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9813
Thank you for contributing to Terra.
@cerner/terra