Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate python 3.8 support #194

Merged
merged 1 commit into from
Dec 21, 2024
Merged

deprecate python 3.8 support #194

merged 1 commit into from
Dec 21, 2024

Conversation

bmw
Copy link
Member

@bmw bmw commented Dec 18, 2024

this is based on #165

@bmw bmw requested review from a team and wgreenberg and removed request for a team December 18, 2024 17:51
@bmw
Copy link
Member Author

bmw commented Dec 18, 2024

sorry for the followup commits here. i initially started removing importlib_resources as it's not needed once we only depend on python 3.9+, but since this PR only deprecates python 3.8 support, we can't do that quite yet

Copy link
Contributor

@ohemorange ohemorange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ohemorange ohemorange merged commit 2731969 into master Dec 21, 2024
28 checks passed
@ohemorange ohemorange deleted the deprecate-py38 branch December 21, 2024 00:17
jvanasco pushed a commit to jvanasco/josepy that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants