Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Bump #66

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Dependency Bump #66

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7da8636
Dependency Bump
Joroks Sep 3, 2024
147c015
Dependency Bump
Joroks Sep 3, 2024
7ba920d
Test for MPI
Joroks Sep 3, 2024
04ae5c1
Ignore local preferences
Joroks Sep 4, 2024
6a5a3ac
Check config on startup
Joroks Sep 4, 2024
05f244c
regenerate api.jl
Joroks Sep 4, 2024
643efca
Dependency Bump
Joroks Sep 4, 2024
9341c86
Merge branch 'dep_bump' of github.com:Joroks/LAMMPS.jl into dep_bump
Joroks Sep 4, 2024
8b6bb40
Fail test, if MPI is not enabled
Joroks Sep 4, 2024
85bb97c
fix mpitest
Joroks Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,10 +352,6 @@ end
end

@testset "MPI" begin
if Sys.iswindows()
@test LAMMPS.API.lammps_config_has_mpi_support() == 0
else
@test LAMMPS.API.lammps_config_has_mpi_support() != 0
@test success(pipeline(`$(MPI.mpiexec()) -n 2 $(Base.julia_cmd()) mpitest.jl`, stderr=stderr, stdout=stdout))
end
@test LAMMPS.API.lammps_config_has_mpi_support() != 0
@test success(pipeline(`$(MPI.mpiexec()) -n 2 $(Base.julia_cmd()) mpitest.jl`, stderr=stderr, stdout=stdout))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant, make the mpitest.jl fail if it is run without MPI support. In my earlier hybris, I trusted this test to not work without MPI support, but it would just happily run with LAMMPS not using MPI.

end
Loading