Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for SubjectAltNameWarning exception in distributed_cleanup.py #2911

Merged

Conversation

craigcomstock
Copy link
Contributor

If urllib3 is v2.0 and greater then errors are produced when no subjectAltName is in the certificate. For less than v2.0 we want to silence the SubjectAltNameWarning exception.

Ticket: ENT-11875
Changelog: none

with cfengine/buildscripts#1454

@craigcomstock
Copy link
Contributor Author

getting a package here for ubu24 Build Status

@craigcomstock craigcomstock marked this pull request as draft June 13, 2024 19:30
@craigcomstock craigcomstock marked this pull request as ready for review June 14, 2024 15:00
…p.py

If urllib3 is v2.0 and greater then errors are produced when no subjectAltName is in the certificate.
For less than v2.0 we want to silence the SubjectAltNameWarning exception.

Ticket: ENT-11875
Changelog: none
@craigcomstock craigcomstock force-pushed the ubu24-dist-cleanup-py-fixes branch from 03c61a7 to f6d2178 Compare June 14, 2024 15:33
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unqualified approval here, but seems reasonable to me.

@craigcomstock craigcomstock merged commit 8c8659c into cfengine:master Jun 18, 2024
4 checks passed
@craigcomstock craigcomstock deleted the ubu24-dist-cleanup-py-fixes branch June 18, 2024 14:32
@craigcomstock
Copy link
Contributor Author

cherry picks
#2914
#2913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants