Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with yum package module regarding packages with epoch not validating #2970

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fixed issue with yum package module regarding packages with epoch not validating #2970

merged 3 commits into from
Dec 19, 2024

Conversation

craigcomstock
Copy link
Contributor

@craigcomstock craigcomstock commented Dec 18, 2024 •
edited
Loading

No description provided.

@craigcomstock
Copy link
Contributor Author

Will fix acceptance_tests and check valgrind_tests.

@craigcomstock
Fixed issue with yum package module regarding packages with epoch not…
32110fe 
… validating

Packages would be installed but the promise would fail due to the installed list not including the epoch number.
The updates list generated by the module included the epoch number so validation would fail.

e.g. findutils:1:4.8.0-7.el9:x86_64 would not match findutils:4.8.0-7.el9:x86_64

Fix this by including epoch in rpm_output_format and removing (none): where the package has no epoch.

Ticket: ENT-12538
Changelog: title
nickanderson
nickanderson reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@nickanderson nickanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me but not a good person to judge the code

@craigcomstock
Copy link
Contributor Author

Makes sense to me but not a good person to judge the code

Thanks! I requested a few python coders review.

larsewi
larsewi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/valgring/valgrind/g in second commit. Looks good 🚀

modules/packages/vendored/yum.mustache Outdated Show resolved Hide resolved
@craigcomstock craigcomstock merged commit b3482ab into cfengine:master Dec 19, 2024
4 checks passed
@craigcomstock craigcomstock deleted the ENT-12538/master branch December 19, 2024 17:34
@craigcomstock
Copy link
Contributor Author

cherry picks
#2972
#2971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickanderson nickanderson nickanderson left review comments

@larsewi larsewi larsewi approved these changes

@olehermanse olehermanse Awaiting requested review from olehermanse

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigcomstock @nickanderson @larsewi