Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

50 fix confirmation email for beta language #51

Merged
merged 4 commits into from
Dec 4, 2024
Merged

50 fix confirmation email for beta language #51

merged 4 commits into from
Dec 4, 2024

Conversation

jcadam14
Copy link
Contributor

@jcadam14 jcadam14 commented Dec 4, 2024

Closes #50

Changes confirmation email to have beta and prod body text, as well as [BETA] in the subject only if not prod.

Changed the beta text based on suggestions.

@jcadam14 jcadam14 self-assigned this Dec 4, 2024
@jcadam14 jcadam14 linked an issue Dec 4, 2024 that may be closed by this pull request
fix confirmation email for beta language #50
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  src/regtech_mail_api
  internal.py
  mailer.py 78-79
Project Total  

This report was generated by python-coverage-comment-action

@jcadam14
Copy link
Contributor Author

jcadam14 commented Dec 4, 2024

Ignore the snyk tests. They're failing again for some reason. They used to fail all the time, no visibility into why, then the past 3 PRs they weren't, now they are again.

@jcadam14
Copy link
Contributor Author

jcadam14 commented Dec 4, 2024

Ok was able to run snyk locally and it is throwing these:

Issues with no direct upgrade or patch:
  ✗ Timing Attack [High Severity][https://security.snyk.io/vuln/SNYK-PYTHON-ECDSA-6184115] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  No upgrade or patch available
  ✗ Missing Encryption of Sensitive Data [High Severity][https://security.snyk.io/vuln/SNYK-PYTHON-ECDSA-6219992] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  No upgrade or patch available
  ✗ Improper Verification of Cryptographic Signature [High Severity][https://security.snyk.io/vuln/SNYK-PYTHON-PYTHONJOSE-6674053] in [email protected]
    introduced by [email protected] > [email protected]
  No upgrade or patch available
  ✗ Resource Consumption [High Severity][https://security.snyk.io/vuln/SNYK-PYTHON-PYTHONJOSE-6674054] in [email protected]
    introduced by [email protected] > [email protected]
  No upgrade or patch available

This is being fixed as part of cfpb/regtech-api-commons#163

@jcadam14
Copy link
Contributor Author

jcadam14 commented Dec 4, 2024

Ok now it's ready for review (please see the comment above about the Snyk failure, which can be ignored for now)

lchen-2101
lchen-2101 approved these changes Dec 4, 2024
View reviewed changes
Copy link

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit 89eeda6 into main Dec 4, 2024
3 of 4 checks passed
@lchen-2101 lchen-2101 deleted the 50-fix-confirmation-email-for-beta-language branch December 4, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchen-2101 lchen-2101 lchen-2101 approved these changes

@hkeeler hkeeler Awaiting requested review from hkeeler

@guffee23 guffee23 Awaiting requested review from guffee23

@nargis-sultani nargis-sultani Awaiting requested review from nargis-sultani

Assignees

@jcadam14 jcadam14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix confirmation email for beta language
2 participants
@jcadam14 @lchen-2101