Improve FLP specification #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/226
branch
from
a571652 to
3112814
Compare
|
Rebased. |
divergentdave
approved these changes
Oct 3, 2024
Clean up the reference code a bit so that it can be excerpted in the draft: add comments; use more meaningful variable names; and make variables consistent across the prover and verifier. We've also replaced `prove_wrapped()` and `query_wrapped()` with class methods on `ProveGadget` and `QueryGadget` respectively. This way the listing of these classes is a little tidier. Replace the current description of the algorithms with the reference code for and a brief overview of each. This entails defining `poly_eval()`, which we've done in the conventions section. `ProveGadget` and `QueryGadget` are listed in the appendix, as their descriptions are a bit tedious and their functionality is relatively straightforward. Note however that these are load-bearing parts of the specification. Other things: * Remove the "Encoding" subsection, which is pretty useless. Instead, we just say how these are instantiated in the "Validity Circuit" section. * Remove calls to `check_valid_eval()` from the draft, as this more useful for testing than it is as part of the spec. * Clean up the parameter tables, including indicating types. * Do another pass of the overview and tighten things up a bit. Co-authored-by: David Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #226.
Clean up the reference code a bit so that it can be excerpted in the draft: add comments; use more meaningful variable names; and make variables consistent across the prover and verifier. We've also replaced
prove_wrapped()andquery_wrapped()with class methods onProveGadgetandQueryGadgetrespectively. This way the listing of these classes is a little tidier.Replace the current description of the algorithms with the reference code for and a brief overview of each. This entails defining
poly_eval(), which we've done in the conventions section.ProveGadgetandQueryGadgetare listed in the appendix, as their descriptions are a bit tedious and their functionality is relatively straightforward. Note however that these are load-bearing parts of the specification.Other things:
Remove the "Encoding" subsection, which is pretty useless. Instead, we just say how these are instantiated in the "Validity Circuit" section.
Remove calls to
check_valid_eval()from the draft, as this more useful for testing than it is as part of the spec.Clean up the parameter tables, including indicating types.
Do another pass of the overview and tighten things up a bit.