Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove this.render on device change (fixes #137) #138

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix: Remove this.render on device change (fixes #137) #138

merged 1 commit into from
Nov 21, 2023

Conversation

joe-allen-89
Copy link
Contributor

#137

Fix

@joe-allen-89 joe-allen-89 self-assigned this Nov 7, 2023
@joe-allen-89 joe-allen-89 linked an issue Nov 7, 2023 that may be closed by this pull request
Renders multiple instances of Hint on Hotgrid components #137
Closed
kirsty-hames
kirsty-hames approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks. Tested on Mac Safari, Chrome, FF and Chrome on Android tablet.

@oliverfoster oliverfoster merged commit c9a6523 into master Nov 21, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
@semantic-release-bot
Chore(release): 4.4.4 [skip ci]
245d2dc 
## [4.4.4](v4.4.3...v4.4.4) (2023-11-21)

### Fix

* Remove this.render on device change (#138) ([c9a6523](c9a6523)), closes [#138](#138)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kirsty-hames kirsty-hames deleted the issue/137 branch November 21, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renders multiple instances of Hint on Hotgrid components
3 participants
@joe-allen-89 @kirsty-hames @oliverfoster