Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Updates for AAT v1 compatibility (fixes #20) #21

Merged
merged 9 commits into from
Jan 14, 2025
Merged

New: Updates for AAT v1 compatibility (fixes #20) #21

merged 9 commits into from
Jan 14, 2025

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Dec 5, 2024 •
edited
Loading

Fix #20

New

  • Adds AAT v1 schemas
  • Adds global scrollDown string: _globals._extensions._scrollPrompt.scrollDown

Update

  • Documentation updates, PR template typo fix, cleanup properties.schema

@swashbuck swashbuck self-assigned this Dec 5, 2024
@swashbuck swashbuck marked this pull request as ready for review December 5, 2024 22:34
kirsty-hames
kirsty-hames approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @swashbuck and global instruction working as expected. I haven't been able to test this in a v1 AAT instance but I ran this through a JSON schema validator and all good.

Not related to this PR as I was able to replicate in Master but I was unable to get the scroll prompt working on the menu. Are you able to?

@swashbuck
Copy link
Contributor Author

Not related to this PR as I was able to replicate in Master but I was unable to get the scroll prompt working on the menu.

@kirsty-hames Looks like the menu compatibility broke in this PR. I've added a fix just now.

@kirsty-hames
Copy link
Contributor

Thanks @swashbuck. I can confirm the menu compatibility issue is fixed.

@oliverfoster oliverfoster merged commit 2008186 into master Jan 14, 2025
@oliverfoster oliverfoster deleted the issue/20 branch January 14, 2025 12:20
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@semantic-release-bot
Chore(release): 1.2.0 [skip ci]
43c9527 
# [1.2.0](v1.1.1...v1.2.0) (2025-01-14)

### New

* Updates for AAT v1 compatibility (fixes #20) (#21) ([2008186](2008186)), closes [#20](#20) [#21](#21)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AAT: Assess for supported plugins inclusion
3 participants
@swashbuck @kirsty-hames @oliverfoster