Use dropdown list instead of editbox for box classes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch-sa
approved these changes
Sep 11, 2022
|
Ah, before I forget. Please squash your commits before you merge. So to make rebasing easier ;) |
ch-sa
pushed a commit
that referenced
this pull request
Oct 15, 2022
* Use dropdown list instead of editbox for box classes * not ignore labels/schema * mypy and black * change to_open3d_point_cloud, to_point_cloud to staticmethod-s * remove print * change stylesheet for QComboVox#current_class_dropdown
ch-sa
pushed a commit
that referenced
this pull request
Dec 4, 2022
* Use dropdown list instead of editbox for box classes * not ignore labels/schema * mypy and black * change to_open3d_point_cloud, to_point_cloud to staticmethod-s * remove print * change stylesheet for QComboVox#current_class_dropdown
ch-sa
pushed a commit
that referenced
this pull request
Dec 4, 2022
* Use dropdown list instead of editbox for box classes * not ignore labels/schema * mypy and black * change to_open3d_point_cloud, to_point_cloud to staticmethod-s * remove print * change stylesheet for QComboVox#current_class_dropdown
ch-sa
pushed a commit
that referenced
this pull request
Dec 4, 2022
* Use dropdown list instead of editbox for box classes * not ignore labels/schema * mypy and black * change to_open3d_point_cloud, to_point_cloud to staticmethod-s * remove print * change stylesheet for QComboVox#current_class_dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original plan was to put this together with the PR that assigning box labels to point labels but I realise that it's a logically separated functionality, so I split it to this PR so it's easier to review component-by-component.
This PR replace the class edit box to class drop down box to force the user to have a restricted set of options when setting the box classes as well as the point classes. Because of the nature of it, the class definition in
config.iniis removed. Ideally,std_object_classshould be removed as well but because there is another PR addressing that, it is retained for now.The label_definition concept is therefore shared across two modes. This also paves the way for the label definition
setupidea.Expected behaviours:
std_object_class