Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registers for USBHD #1

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Add registers for USBHD #1

merged 3 commits into from
Apr 30, 2024

Conversation

ExplodingWaffle
Copy link
Contributor

No description provided.

@andelf andelf self-requested a review April 29, 2024 17:07
ExplodingWaffle and others added 3 commits May 1, 2024 00:35
- rename from USBHD, USBHS is the new name in newest datasheet
- split register blocks, using extends
@andelf
Copy link
Contributor

andelf commented Apr 30, 2024

Thanks for the work! As ch32-hal didn't have USB support yet, I don't know the best practice here.
So I did some refactoring based on max back compatibility and code reuse.

  • rename from USBHD, USBHS is the name in the newest datasheet
  • split register blocks, using extends
  • use usb_ as the basic prefix. v3hs as the version name.

@andelf andelf merged commit 5572f61 into ch32-rs:main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants