Support default package icon in offline scenarios (loic-sharma#435)

chaghi · Jan 4, 2020 · 847142f · 847142f
1 parent 8404130
commit 847142f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/BaGet.UI/src/DisplayPackage/DisplayPackage.tsx b/src/BaGet.UI/src/DisplayPackage/DisplayPackage.tsx
@@ -14,6 +14,7 @@ import SourceRepository from './SourceRepository';
 import { Versions, IPackageVersion } from './Versions';
 
 import './DisplayPackage.css';
+import DefaultPackageIcon from "../default-package-icon-256x256.png";
 
 interface IDisplayPackageProps {
   match: {
@@ -60,8 +61,6 @@ class DisplayPackage extends React.Component<IDisplayPackageProps, IDisplayPacka
     package: undefined,
   };
 
-  private readonly defaultIconUrl: string = 'https://www.nuget.org/Content/gallery/img/default-package-icon-256x256.png';
-
   private id: string;
   private version?: string;
 
@@ -210,7 +209,7 @@ class DisplayPackage extends React.Component<IDisplayPackageProps, IDisplayPacka
         <div className="row display-package">
           <aside className="col-sm-1 package-icon">
             <img
-              src={this.state.package.iconUrl}
+              src={this.state.package.iconUrl || DefaultPackageIcon}
               className="img-responsive"
               onError={this.loadDefaultIcon}
               alt="The package icon" />
@@ -307,7 +306,7 @@ class DisplayPackage extends React.Component<IDisplayPackageProps, IDisplayPacka
   }
 
   private loadDefaultIcon = (e: React.SyntheticEvent<HTMLImageElement>) => {
-    e.currentTarget.src = this.defaultIconUrl;
+    e.currentTarget.src = DefaultPackageIcon;
   }
 
   private normalizeVersion(version: string): string {

diff --git a/src/BaGet.UI/src/SearchResults.tsx b/src/BaGet.UI/src/SearchResults.tsx
@@ -4,6 +4,7 @@ import { Checkbox, Dropdown, IDropdownOption, SelectableOptionMenuItemType } fro
 import * as React from 'react';
 import { Link } from 'react-router-dom';
 import './SearchResults.css';
+import DefaultPackageIcon from "./default-package-icon-256x256.png";
 
 interface ISearchResultsProps {
   input: string;
@@ -32,7 +33,6 @@ interface ISearchResponse {
 
 class SearchResults extends React.Component<ISearchResultsProps, ISearchResultsState> {
 
-  private readonly defaultIconUrl: string = 'https://www.nuget.org/Content/gallery/img/default-package-icon-256x256.png';
   private resultsController?: AbortController;
 
   constructor(props: ISearchResultsProps) {
@@ -160,7 +160,7 @@ class SearchResults extends React.Component<ISearchResultsProps, ISearchResultsS
           <div key={value.id} className="row search-result">
             <div className="col-sm-1 hidden-xs hidden-sm">
               <img
-                src={value.iconUrl || this.defaultIconUrl}
+                src={value.iconUrl || DefaultPackageIcon}
                 className="package-icon img-responsive"
                 onError={this.loadDefaultIcon}
                 alt="The package icon" />
@@ -272,7 +272,7 @@ class SearchResults extends React.Component<ISearchResultsProps, ISearchResultsS
   }
 
   private loadDefaultIcon = (e: React.SyntheticEvent<HTMLImageElement>) => {
-    e.currentTarget.src = this.defaultIconUrl;
+    e.currentTarget.src = DefaultPackageIcon;
   }
 
   private onChangePackageType = (e: React.FormEvent<HTMLDivElement>, option?: IDropdownOption) : void => {

diff --git a/src/BaGet.UI/src/default-package-icon-256x256.png b/src/BaGet.UI/src/default-package-icon-256x256.png