Skip to content

Commit

Permalink
Replace own IS_DOCKER by base image DOTNET_RUNNING_IN_CONTAINER (loic…
Browse files Browse the repository at this point in the history
  • Loading branch information
tmds authored and loic-sharma committed Dec 6, 2018
1 parent 29b93c6 commit ecf2c41
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ EXPOSE 80

FROM microsoft/dotnet:2.1-sdk AS build
WORKDIR /src
ENV IS_DOCKER true
COPY /src .
RUN dotnet restore BaGet
RUN dotnet build BaGet -c Release -o /app
Expand Down
4 changes: 2 additions & 2 deletions src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
</PropertyGroup>

<ItemGroup Condition="$(IS_DOCKER) == ''">
<ItemGroup Condition="$(DOTNET_RUNNING_IN_CONTAINER) == ''">
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta-63127-02" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup Condition="$(IsPackable) == 'true' AND $(IS_DOCKER) == ''">
<ItemGroup Condition="$(IsPackable) == 'true' AND $(DOTNET_RUNNING_IN_CONTAINER) == ''">
<PackageReference Include="Nerdbank.GitVersioning" Version="2.2.13" PrivateAssets="all" />
</ItemGroup>

Expand Down

0 comments on commit ecf2c41

Please sign in to comment.