fix: recurse custom object-returning inspect (#39)

* test: inspect with custom object-returning inspect * fix: recursively inspect customInspect output Co-authored-by: Keith Cirkel <[email protected]>
chaijs · Feb 4, 2021 · c66dc49 · c66dc49
1 parent 8d6cc83
commit c66dc49
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -129,7 +129,7 @@ export function inspect(value, options) {
   // If `options.customInspect` is set to true then try to use the custom inspector
   if (customInspect && value) {
     const output = inspectCustom(value, options, type)
-    if (output) return output
+    if (output) return inspect(output, options)
   }
 
   const proto = value ? Object.getPrototypeOf(value) : false

diff --git a/test/acceptance.js b/test/acceptance.js
@@ -30,7 +30,7 @@ describe('objects', () => {
     const obj = {
       inspect: () => 1,
     }
-    expect(inspect(obj, { customInspect: true })).to.equal(1)
+    expect(inspect(obj, { customInspect: true })).to.equal('1')
   })
 
   it('uses a custom deeply nested inspect function if `customInspect` is turned on', () => {
@@ -39,6 +39,16 @@ describe('objects', () => {
         inspect: (depth, options) => options.stylize('Object content', 'string'),
       },
     }
-    expect(inspect(obj, { customInspect: true })).to.equal('{ sub: Object content }')
+    expect(inspect(obj, { customInspect: true })).to.equal("{ sub: 'Object content' }")
+  })
+
+  it('inspect with custom object-returning inspect', () => {
+    const obj = {
+      sub: {
+        inspect: () => ({ foo: 'bar' }),
+      },
+    }
+
+    expect(inspect(obj, { customInspect: true })).to.equal("{ sub: { foo: 'bar' } }")
   })
 })