Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CmAccount instancing in BuyBookingToken function #63

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

VjeraTurk
Copy link
Contributor

@VjeraTurk VjeraTurk commented Oct 25, 2024

Why this should be merged & How this works

  • Fixes using the bot address ( transportOpts.From) instead of cmAccount address.
  • Skips the checkAndApproveAllowance before minting (the approving the allowance is done during the buy operation that is triggered by the cmAccount.buyBookingToken() function call).
  • Uses CAM instead of EURSH in mintnbuy.go example
  • Add example for Test Token in mintnbuy.go example (with comments)

How this was tested

Buy running mintnbuy.go and via postman using Test Token, CAM and EUR.

@VjeraTurk VjeraTurk requested review from evlekht, nkoljanin and havan and removed request for evlekht and nkoljanin October 25, 2024 07:55
@VjeraTurk
Copy link
Contributor Author

VjeraTurk commented Oct 28, 2024

DONE: Test with test token @nkoljanin

@VjeraTurk VjeraTurk marked this pull request as ready for review October 28, 2024 11:21
evlekht
evlekht previously approved these changes Oct 28, 2024
@VjeraTurk VjeraTurk merged commit b0a7839 into dev Oct 28, 2024
3 checks passed
@VjeraTurk VjeraTurk deleted the VjeraTruk/fix-buy-booking-token branch October 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants