Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print protocol version in log #76

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

evlekht
Copy link
Member

@evlekht evlekht commented Dec 3, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new constants package for improved versioning and logging.
    • Added a constant for ProtocolVersion set to "v10.0.0".
  • Bug Fixes

    • Updated logging statements to reflect the new constants for version and commit information.
  • Chores

    • Modified build script to utilize the new constants for version and Git commit during the build process.

This comment was marked as outdated.

@evlekht evlekht requested review from havan and VjeraTurk December 3, 2024 14:43
Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also include the SHAs from buf.build and github for the protocol and contract bindings?

buf.build/gen/go/chain4travel/camino-messenger-protocol/grpc/go v1.5.1-20240924170438-a97744087df6.1
buf.build/gen/go/chain4travel/camino-messenger-protocol/protocolbuffers/go v1.34.2-20240924170438-a97744087df6.2
github.com/chain4travel/camino-messenger-contracts/go/contracts v0.0.0-20241024152339-d7c3c6e5c377

Something like:

	grpc: a97744087df6
	protocolbuffers: a97744087df6
	contracts: d7c3c6e5c377

This way we can identify the exact buf.build sdk used by the compiled binary.

@evlekht evlekht merged commit 77eb70d into dev Dec 3, 2024
5 checks passed
@evlekht evlekht deleted the evlekht/print-protocol-version branch December 3, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants