Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors in the dev-env #137

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Fix build errors in the dev-env #137

merged 1 commit into from
Oct 18, 2024

Conversation

ericcornelissen
Copy link
Collaborator

Summary

At some point building in the container started failing with the error:

error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping.

this fixes that by adding the project directory inside the container as a folder trusted by git so that the Go compiler can get the VCS information.

An alternative would be to disable the VCS stamping, but it seems pretty useful to me to have this information available through go version -m ./ghasum for debugging purposes.

@ericcornelissen ericcornelissen merged commit 1d30cbf into main Oct 18, 2024
9 checks passed
@ericcornelissen ericcornelissen deleted the fix-dev-env branch October 18, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant