Extensibility proof-of-concept #15
Conversation
chancancode
force-pushed
the
extensibility
branch
from
9b91000 to
fdabf27
Compare
| storage: Storage, | ||
| keys: string[], | ||
| ): Promise<Array<string | null>> { | ||
| if (isEnabled(storage, 'batch')) { |
There was a problem hiding this comment.
This allows type safe access to the 'batch' extension
| export type Deserializer<T> = (serialized: SerializedObject) => T; | ||
|
|
||
| export default abstract class JSONStorage extends Service { | ||
| abstract storage: Storage; |
There was a problem hiding this comment.
This requires the app to inject (and therefore compose over) the store, rather than extending it directly
| new (scope: Scope): Storage & Ext; | ||
| }; | ||
|
|
||
| const Extensions = new WeakMap<typeof Storage, Set<keyof Registry>>(); |
There was a problem hiding this comment.
On second thought, using a WeakMap here is not quite right; when a class implements/enables a feature, its subclass should also be considered an implementor, so something on the prototype inheritance chain works better. That's a small detail for production consideration, doesn't really affect the overall point this demo is trying to make
| import JSONStorage, { type Deserializer } from 'ember-storage-json'; | ||
| import Storage from './storage'; | ||
|
|
||
| export class AppJSONStorage extends JSONStorage { |
There was a problem hiding this comment.
This is only exported for type reasons, the default export is what's important
| import Storage from './storage'; | ||
|
|
||
| export class AppJSONStorage extends JSONStorage { | ||
| storage = service(this, Storage); |
There was a problem hiding this comment.
Injects the store as is required – also pulls in the module dependency naturally
|
|
||
| const found: T[] = []; | ||
|
|
||
| for (const [key, value] of this.storage.entries()) { |
| import { enable } from 'ember-storage/extensions'; | ||
| import { type StorageWithBatching } from 'ember-storage-batch'; | ||
|
|
||
| export class AppStorage extends Storage implements StorageWithBatching { |
There was a problem hiding this comment.
This implements StorageWithBatching is nice but optional – even if you don't do this, you will still get the type error down below
| this.#storage.removeItem(this.keyFor(key)); | ||
| } | ||
|
|
||
| *entries(): Generator<[string, string], void, void> { |
There was a problem hiding this comment.
This is accessed in the JSONStorage service as proof that these custom extensions can be used in the app just fine
| // This is type safe! | ||
| // Even if you didn't write `implements StorageWithBatching` above, | ||
| // you will still get an error here. | ||
| enable(AppStorage, 'batch'); |
There was a problem hiding this comment.
This will error in TypeScript if AppStorage (the instance side) does not in fact implement the 'batch' interface
No description provided.