-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update doc.s for used components #1791
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## next #1791 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 147 147
Lines 2735 2736 +1
Branches 712 714 +2
=======================================
+ Hits 2530 2531 +1
Misses 189 189
Partials 16 16
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
c4b5266
to
fd3f8d9
Compare
- use preset on embedded Text Component - add clearer documentation for individual stories - update snapshots
- mark some areas for refinement at the next major
- remove redundant stories - add in story descriptions - update snapshots
- decouple linkage from InputLabel type as well
- remove redundant stories
5989776
to
76f659a
Compare
76f659a
to
7d7a4f8
Compare
dc9292e
to
c98c9e5
Compare
Context: This includes a ton of improvements on the component docs, mostly addressing inconsistencies but also adding details to individual stories to help give context when looking at the Docs tab. For example, compare the following:
The checked components above contain the ones I modify here. They are drawn from the omlet reports on component usage, so I am prioritizing the changes for those. There are some soft best-practices coming from this work, so there are some notes attached to some changes for reference. |
@jeremiah-clothier as someone who worked on the pilots directly, any insights into undocumented or confusing things would be appreciated |
Summary:
Adding better documentation for the components used in current projects:
ClickableStyleButtonGroupButtonFiltersCheckboxFieldFiltersPopoverFor each component:
Story
created, usingArgs
)ComponenNameProps
over justProps
when sub-components need importing elsewhere)Extract
to avoid bifurcating common variant names/values**Default is 'value'.**
)render
Test Plan:
edu-stack
ortraject
as a sanity check if changes affect build or deploy, or are breaking, such as token changes, widely used component updates, hooks changes, and major dependency upgrades.