chore: update some major versions #1800
Conversation
| @@ -12,7 +12,7 @@ export interface Props { | |||
| /** | |||
| * BETA: This component is still a work in progress and is subject to change. | |||
| * | |||
| * `import {{inBraces name}} from "@chanzuckerberg/eds";` | |||
| * `import {{inBraces (pascalCase name)}} from "@chanzuckerberg/eds";` | |||
There was a problem hiding this comment.
I removed the dep on pascal-case rather than update it.
Here I've removed pascal-case from our custom inBraces helper, and am using handlebars's built-in helper instead.
| @@ -8,7 +7,7 @@ module.exports = (plop) => { | |||
|
|
|||
| // This helper allows us to place a variable inside curly braces without spaces | |||
| // between the text and the braces. | |||
| plop.setHelper('inBraces', (txt) => `{${pascalCase.pascalCase(txt)}}`); | |||
| plop.setHelper('inBraces', (txt) => `{${txt}}`); | |||
| @@ -1,5 +1,4 @@ | |||
| const pascalCase = require('pascal-case'); | |||
| const { snakeCase } = require('snake-case'); | |||
| const { snakeCase } = require('lodash'); | |||
There was a problem hiding this comment.
Using lodash for snake case, so we don't have to update snake-case.
| path: 'src/components/{{pascalCase name}}/{{pascalCase name}}.stories.tsx', | ||
| templateFile: 'plop-templates/Component/Component.stories.tsx.hbs', | ||
| path: 'src/components/{{pascalCase name}}/{{pascalCase name}}.stories.ts', | ||
| templateFile: 'plop-templates/Component/Component.stories.ts.hbs', |
There was a problem hiding this comment.
yarn plop wasn't working. Needed to update the path here.
It's possible no one is using plop. Should we remove it?
Codecov Report
@@ Coverage Diff @@
## next #1800 +/- ##
==========================================
+ Coverage 92.57% 92.61% +0.03%
==========================================
Files 147 147
Lines 2735 2735
Branches 712 712
==========================================
+ Hits 2532 2533 +1
Misses 187 187
+ Partials 16 15 -1 see 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
size-limit report 📦
|
|
Thanks 🙏 |
Update some major versions of packages.
These are the "easy" ones, that are dropping support for Node versions or other things that don't really affect our code.