Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ToastNotification): fix typo in prop name #2122

Merged
merged 3 commits into from
Jan 3, 2025
Merged

fix(ToastNotification): fix typo in prop name #2122

merged 3 commits into from
Jan 3, 2025

Conversation

booc0mtaco
Copy link
Contributor

  • add in dismissType
  • add in tests and console messages so make sure the new field falls back

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco
fix(ToastNotification): fix typo in prop name
8f75d15 
- add in dismissType
- add in tests and console messages so make sure the new field falls back
@booc0mtaco booc0mtaco requested review from a team and forgeabout January 3, 2025 00:52
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (d77ae83) to head (b9caf4a).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2122   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         114      114           
  Lines        2825     2829    +4     
  Branches      764      767    +3     
=======================================
+ Hits         2744     2748    +4     
  Misses         77       77           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

size-limit report 📦

Path Size
components 95.47 KB (+0.19% 🔺)
styles 29.85 KB (0%)

forgeabout
forgeabout requested changes Jan 3, 2025
View reviewed changes
Copy link

@forgeabout forgeabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a logic error, but let me know if I'm missing something.

src/components/ToastNotification/ToastNotification.tsx Outdated Show resolved Hide resolved
src/components/ToastNotification/ToastNotification.tsx Outdated Show resolved Hide resolved
src/components/ToastNotification/ToastNotification.tsx Show resolved Hide resolved
@booc0mtaco booc0mtaco merged commit 8c70d28 into next Jan 3, 2025
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1453 branch January 3, 2025 22:27
@booc0mtaco booc0mtaco mentioned this pull request Jan 21, 2025
Merged
booc0mtaco added a commit that referenced this pull request Jan 21, 2025
@booc0mtaco
Merge pull request #2127 from chanzuckerberg/release-v15.10.0
477545c 
## [15.10.0](v15.9.0...v15.10.0) (2025-01-21)

[Storybook](https://61313967cde49b003ae2a860-ppfzyqbjud.chromatic.com/)

### Features

* **TabGroup:** update handling for tab item hover states ([#2124](#2124)) ([8b6cb4e](8b6cb4e))


### Bug Fixes

* **ToastNotification:** fix typo in prop name ([#2122](#2122)) ([8c70d28](8c70d28))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forgeabout forgeabout forgeabout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @forgeabout