Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move cors configuration to root mux #2901

Merged
merged 1 commit into from
Jan 5, 2024
Merged

feat: move cors configuration to root mux #2901

merged 1 commit into from
Jan 5, 2024

Conversation

hspitzley-czi
Copy link
Contributor

@hspitzley-czi hspitzley-czi commented Jan 5, 2024 •
edited by github-actions bot
Loading

CCIE-2216
Summary Configure CORS for v2 routes
Type Task Task
Status In Progress

Move the CORS configuration to the root mux so it applies to both v1 and v2 routes, allowing /v2/app-configs to be used by EngPortal's Happy plugin

@hspitzley-czi hspitzley-czi requested a review from a team as a code owner January 5, 2024 18:14
@hspitzley-czi hspitzley-czi requested review from netvisao and removed request for a team January 5, 2024 18:14
@hspitzley-czi hspitzley-czi merged commit 380dd21 into main Jan 5, 2024
31 checks passed
@hspitzley-czi hspitzley-czi deleted the CCIE-2216-configure-cors-for-v-2-routes branch January 5, 2024 19:23
@czi-github-helper czi-github-helper bot mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlokshin-czi alexlokshin-czi alexlokshin-czi approved these changes

@netvisao netvisao Awaiting requested review from netvisao netvisao is a code owner automatically assigned from chanzuckerberg/infra-eng-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hspitzley-czi @alexlokshin-czi